Put DeployCommand behind a feature flag#10613
Merged
mitchdenny merged 3 commits intorelease/9.4from Jul 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements feature flag gating for the DeployCommand in the Aspire CLI. The deploy command is now hidden behind a feature flag (deployCommandEnabled) that defaults to false, preventing users from accessing the command until a built-in deployer is available.
- Added a new feature flag
DeployCommandEnabledto control deploy command visibility - Updated RootCommand to conditionally add the deploy command based on the feature flag
- Modified all existing deploy command tests to enable the feature flag
- Added new tests to verify the feature flag behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Cli/KnownFeatures.cs | Added DeployCommandEnabled feature flag constant |
| src/Aspire.Cli/Commands/RootCommand.cs | Added conditional logic to only register deploy command when feature flag is enabled |
| tests/Aspire.Cli.Tests/Commands/DeployCommandTests.cs | Updated all test methods to enable the feature flag and added tests for feature flag behavior |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
davidfowl
approved these changes
Jul 23, 2025
Contributor
Author
|
@joperezr @mitchdenny Can I get reviews/help merging this in? |
Member
|
/backport to release/9.4 |
Contributor
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16460221301 |
Contributor
|
@mitchdenny backporting to "release/9.4" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Put DeployCommand behind a feature flag
Using index info to reconstruct a base tree...
M src/Aspire.Cli/Commands/RootCommand.cs
M src/Aspire.Cli/KnownFeatures.cs
M tests/Aspire.Cli.Tests/Commands/DeployCommandTests.cs
Falling back to patching base and 3-way merge...
Auto-merging tests/Aspire.Cli.Tests/Commands/DeployCommandTests.cs
CONFLICT (content): Merge conflict in tests/Aspire.Cli.Tests/Commands/DeployCommandTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Put DeployCommand behind a feature flag
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
|
@mitchdenny this is in 9.4 only. |
Member
|
Yeah just realized. I was looking at main thinking - why isn't that PR there :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the DeployCommand behind a feature flag until a built-in deployer is available.