Fix HTTP display summary with newer HTTP client telemetry#11737
Merged
Fix HTTP display summary with newer HTTP client telemetry#11737
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11737Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11737" |
davidfowl
reviewed
Sep 30, 2025
| var statusCode = span.Attributes.GetValueWithFallback("http.response.status_code", "http.status_code"); | ||
|
|
||
| return $"HTTP {httpMethod?.ToUpperInvariant()} {statusCode}"; | ||
| var summary = $"HTTP {httpMethod?.ToUpperInvariant()}"; |
Contributor
There was a problem hiding this comment.
This isn't new logic but can httpMethod be null?
Member
Author
There was a problem hiding this comment.
It should never be. It's a required attribute. But this is defensive just in case whatever app sends telemetry doesn't follow the spec correctly.
davidfowl
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11684
After:

Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate