Skip to content

Set OptimizationPreference=Size on Aspire.Cli#12490

Merged
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:CliSize
Oct 30, 2025
Merged

Set OptimizationPreference=Size on Aspire.Cli#12490
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:CliSize

Conversation

@eerhardt
Copy link
Copy Markdown
Member

This results in a size reduction of about 3 MB on win-x64.

This results in a size reduction of about 3 MB on win-x64.
@eerhardt eerhardt requested review from Copilot and mitchdenny and removed request for Copilot October 29, 2025 15:27
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12490

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12490"

@eerhardt eerhardt requested review from davidfowl and radical October 29, 2025 15:28
@eerhardt
Copy link
Copy Markdown
Member Author

I plan to test startup and timing once the PR build is ready.

@davidfowl
Copy link
Copy Markdown
Contributor

Merge if it's good

@eerhardt
Copy link
Copy Markdown
Member Author

It might add a couple milliseconds to --help. On my machine it goes from like 45 milliseconds to ~48 milliseconds. I think we can live with that... 😄

@eerhardt eerhardt enabled auto-merge (squash) October 29, 2025 16:07
@davidfowl
Copy link
Copy Markdown
Contributor

Too slow 😆

@eerhardt eerhardt merged commit c698c41 into microsoft:main Oct 30, 2025
588 of 592 checks passed
@eerhardt eerhardt deleted the CliSize branch October 30, 2025 06:09
@dotnet-policy-service dotnet-policy-service bot added this to the 13.0 milestone Oct 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants