Skip to content

Fix dashboard console logs page flaky test #13768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesNK merged 2 commits into from
Jan 6, 2026
Merged

Fix dashboard console logs page flaky test #13768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feb1efd
Fix dashboard console logs page flaky test
JamesNK Jan 6, 2026
d588eca
Update
JamesNK Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,7 @@ private void LoadLogsForResource(ConsoleLogsSubscription subscription)
await InvokeAsync(StateHasChanged);
}

var hasError = false;
try
{
lock (_updateLogsLock)
Expand Down Expand Up @@ -807,6 +808,7 @@ private void LoadLogsForResource(ConsoleLogsSubscription subscription)
// If the subscription is being canceled then error could be transient from cancellation. Ignore errors during cancellation.
if (!subscription.CancellationToken.IsCancellationRequested)
{
hasError = true;
Logger.LogError(ex, "Error watching logs for resource {ResourceName}.", subscription.Resource.Name);

// For single resource subscriptions or first subscription in "All" mode, update status
Expand All @@ -824,7 +826,8 @@ private void LoadLogsForResource(ConsoleLogsSubscription subscription)

// If the subscription is being canceled then a new one could be starting.
// Don't set the status when finishing because overwrite the status from the new subscription.
if (!subscription.CancellationToken.IsCancellationRequested && !_isSubscribedToAll)
// Also don't overwrite error status if an error occurred.
if (!subscription.CancellationToken.IsCancellationRequested && !_isSubscribedToAll && !hasError)
{
SetStatus(PageViewModel, nameof(Dashboard.Resources.ConsoleLogs.ConsoleLogsFinishedWatchingLogs));
await InvokeAsync(StateHasChanged);
Expand Down