Skip to content

Suppress error notifications for extension prompt cancellation in CLI #14547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamint merged 2 commits into from
Feb 25, 2026
+16 −5
Merged

Suppress error notifications for extension prompt cancellation in CLI #14547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc3e9a
Suppress error notifications for extension cancellation in CLI
adamint Feb 18, 2026
b1d9761
Update src/Aspire.Cli/Program.cs
adamint Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/Aspire.Cli/Interaction/ExtensionInteractionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public ExtensionInteractionService(ConsoleInteractionService consoleInteractionS
var taskFunction = await _extensionTaskChannel.Reader.ReadAsync().ConfigureAwait(false);
await taskFunction.Invoke();
}
catch (Exception ex)
catch (Exception ex) when (ex is not ExtensionOperationCanceledException)
{
await Backchannel.DisplayErrorAsync(ex.Message.RemoveSpectreFormatting(), _cancellationToken);
_consoleInteractionService.DisplayError(ex.Message);
Expand Down Expand Up @@ -148,7 +148,10 @@ await _extensionTaskChannel.Writer.WriteAsync(async () =>
catch (Exception ex)
{
tcs.SetException(ex);
DisplayError(ex.Message);
if (ex is not ExtensionOperationCanceledException)
{
DisplayError(ex.Message);
}
}
}, cancellationToken).ConfigureAwait(false);

Expand Down Expand Up @@ -177,7 +180,10 @@ await _extensionTaskChannel.Writer.WriteAsync(async () =>
catch (Exception ex)
{
tcs.SetException(ex);
DisplayError(ex.Message);
if (ex is not ExtensionOperationCanceledException)
{
DisplayError(ex.Message);
}
}
}, cancellationToken).ConfigureAwait(false);

Expand Down Expand Up @@ -206,7 +212,10 @@ await _extensionTaskChannel.Writer.WriteAsync(async () =>
catch (Exception ex)
{
tcs.SetException(ex);
DisplayError(ex.Message);
if (ex is not ExtensionOperationCanceledException)
{
DisplayError(ex.Message);
}
}
}, cancellationToken).ConfigureAwait(false);

Expand Down
4 changes: 3 additions & 1 deletion src/Aspire.Cli/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,9 @@ public static async Task<int> Main(string[] args)
// Allows logging of exceptions to telemetry.

// Don't log or display cancellation exceptions.
if (!(ex is OperationCanceledException && cts.IsCancellationRequested))
// Check both Ctrl+C cancellation (cts.IsCancellationRequested) and
// extension prompt cancellation (ExtensionOperationCanceledException).
if (!(ex is OperationCanceledException && cts.IsCancellationRequested) && ex is not ExtensionOperationCanceledException)
{
logger.LogError(ex, "An unexpected error occurred.");

Expand Down
Loading