Remove vendored OpenTelemetry.Instrumentation.SqlClient code#14621
Merged
Conversation
The package has now shipped stable, so we can take a dependency on the official package.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14621Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14621" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the vendored OpenTelemetry.Instrumentation.SqlClient code (previously at version 1.7.0-beta.1) and replaces it with a dependency on the official stable package (version 1.15.0). The vendored code was temporarily included in the repository while waiting for the official package to ship stable.
Changes:
- Removed all vendored OpenTelemetry.Instrumentation.SqlClient source files from src/Vendoring/
- Updated project files to reference the official NuGet package instead of vendored code
- Removed vendoring instructions from README.md
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Vendoring/README.md | Removed vendoring instructions for OpenTelemetry.Instrumentation.SqlClient |
| src/Vendoring/OpenTelemetry.Instrumentation.SqlClient/* | Deleted 14 vendored source files (TracerProviderBuilderExtensions.cs, SqlClientTraceInstrumentationOptions.cs, SqlClientInstrumentation.cs, etc.) |
| src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/Aspire.Microsoft.EntityFrameworkCore.SqlServer.csproj | Removed vendored code compilation, added official package reference |
| src/Components/Aspire.Microsoft.Data.SqlClient/Aspire.Microsoft.Data.SqlClient.csproj | Removed vendored code compilation, added official package reference |
| Directory.Packages.props | Added OpenTelemetry.Instrumentation.SqlClient version 1.15.0 to package versions |
sebastienros
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package has now shipped stable, so we can take a dependency on the official package.
I purposefully targeted this to
mainto not cause any instability in the release/13.2 branch.