Add polyglot exports for Azure Sql#14782
Merged
sebastienros merged 2 commits intorelease/13.2from Feb 28, 2026
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14782Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14782" |
76 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ATS/polyglot (TypeScript AppHost) export coverage for Aspire.Hosting.Azure.Sql by annotating key Azure SQL extension methods and introducing a TypeScript ValidationAppHost to exercise the generated SDK surface (per #14069).
Changes:
- Annotate Azure SQL extension methods with
[AspireExport]and mark obsolete APIs with[AspireExportIgnore]. - Add a TypeScript ValidationAppHost for Aspire.Hosting.Azure.Sql (configs, lockfile, and sample apphost).
- Check in generated TypeScript SDK artifacts under
.modules/for the ValidationAppHost.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.Sql/AzureSqlExtensions.cs | Adds ATS export metadata for Azure SQL builder APIs and documents/ignores obsolete methods for polyglot. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/tsconfig.json | Adds TS compile configuration for the validation host, including .modules/ sources. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/package.json | Adds Node/TS project metadata and scripts for the validation host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/package-lock.json | Locks Node dependencies for the validation host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/apphost.ts | Exercises exported APIs (addAzureSqlServer, addDatabase, withDefaultAzureSku, runAsContainer). |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/apphost.run.json | Local run profile for the validation host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.aspire/settings.json | Declares TypeScript AppHost settings and referenced package. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.modules/aspire.ts | Generated TypeScript SDK for the exported capabilities. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.modules/base.ts | Generated TypeScript SDK base utilities. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.modules/transport.ts | Generated TypeScript JSON-RPC transport and handle/callback infrastructure. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.modules/.codegen-hash | Tracks codegen inputs for SDK regeneration. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.Azure.Sql/AzureSqlExtensions.cs:151
WithDefaultAzureSkuis now exported to ATS/TypeScript, but it doesn't validatebuilderfor null. Most other exported extension methods in this repo callArgumentNullException.ThrowIfNull(builder);up front; without that, a malformed ATS call can surface as aNullReferenceExceptioninstead of a clear argument error.
public static IResourceBuilder<AzureSqlDatabaseResource> WithDefaultAzureSku(this IResourceBuilder<AzureSqlDatabaseResource> builder)
{
builder.Resource.UseDefaultAzureSku = true;
return builder;
davidfowl
reviewed
Feb 27, 2026
IEvangelist
approved these changes
Feb 27, 2026
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22507400017 |
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add polyglot exports for Azure Sql * PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069