Skip to content

Publish and sign CLI install scripts#15127

Merged
radical merged 3 commits intorelease/13.2from
ankj/deploy-scripts
Mar 11, 2026
Merged

Publish and sign CLI install scripts#15127
radical merged 3 commits intorelease/13.2from
ankj/deploy-scripts

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Mar 11, 2026

Description

Publishes the Aspire CLI installer scripts together with the existing CLI artifacts on the release/13.2 branch.

  • Publishes get-aspire-cli.sh and get-aspire-cli.ps1 to the blob feed and validates that both scripts exist during publishing.
  • Generates .sha512 checksum files for both install scripts alongside the existing CLI archive checksums.
  • Signs get-aspire-cli.ps1 on Windows only so the PowerShell installer script participates in the existing signing flow without changing non-Windows publishing behavior.

This keeps the installer scripts distributed alongside the CLI archives and brings their checksum and signing behavior in line with the release pipeline expectations.

Dependencies: none.

Validation:

  • ./restore.sh
  • ./build.sh --build /p:SkipNativeBuild=true

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

radical added 3 commits March 11, 2026 00:44
Publish get-aspire-cli.sh and get-aspire-cli.ps1 alongside the Aspire CLI artifacts, validate that both scripts exist during publishing, and include the scripts in the blob feed output.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Generate .sha512 files for get-aspire-cli.sh and get-aspire-cli.ps1 in the packages directory so the published installer scripts match the checksum coverage already provided for Aspire CLI archives.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add get-aspire-cli.ps1 to the signing inputs and file sign metadata only when building on Windows so the PowerShell installer script is signed without affecting non-Windows publishing.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 11, 2026 05:01
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15127

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15127"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Publishes Aspire CLI installer scripts alongside existing CLI release artifacts, including checksum generation and Windows-only signing for the PowerShell installer script.

Changes:

  • Adds Windows signing configuration for get-aspire-cli.ps1.
  • Publishes get-aspire-cli.sh / get-aspire-cli.ps1 and validates they exist during publishing.
  • Generates .sha512 checksum files for the installer scripts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
eng/Signing.props Adds get-aspire-cli.ps1 to the Windows signing inputs/config.
eng/Publishing.props Publishes installer scripts, validates presence, and generates checksum files for them.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

🎬 CLI E2E Test Recordings

The following terminal recordings are available for commit 784558e:

Test Recording
AddPackageInteractiveWhileAppHostRunningDetached ▶️ View Recording
AddPackageWhileAppHostRunningDetached ▶️ View Recording
AgentCommands_AllHelpOutputs_AreCorrect ▶️ View Recording
AgentInitCommand_DefaultSelection_InstallsSkillOnly ▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig ▶️ View Recording
AspireAddPackageVersionToDirectoryPackagesProps ▶️ View Recording
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps ▶️ View Recording
Banner_DisplayedOnFirstRun ▶️ View Recording
Banner_DisplayedWithExplicitFlag ▶️ View Recording
CreateAndDeployToDockerCompose ▶️ View Recording
CreateAndDeployToDockerComposeInteractive ▶️ View Recording
CreateAndPublishToKubernetes ▶️ View Recording
CreateAndRunAspireStarterProject ▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle ▶️ View Recording
CreateAndRunJsReactProject ▶️ View Recording
CreateAndRunPythonReactProject ▶️ View Recording
CreateAndRunTypeScriptStarterProject ▶️ View Recording
CreateEmptyAppHostProject ▶️ View Recording
CreateStartAndStopAspireProject ▶️ View Recording
CreateTypeScriptAppHostWithViteApp ▶️ View Recording
DescribeCommandResolvesReplicaNames ▶️ View Recording
DescribeCommandShowsRunningResources ▶️ View Recording
DetachFormatJsonProducesValidJson ▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig ▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted ▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted ▶️ View Recording
LogsCommandShowsResourceLogs ▶️ View Recording
PsCommandListsRunningAppHost ▶️ View Recording
PsFormatJsonOutputsOnlyJsonToStdout ❌ Upload failed
RestoreGeneratesSdkFiles ▶️ View Recording
RunWithMissingAwaitShowsHelpfulError ▶️ View Recording
SecretCrudOnDotNetAppHost ❌ Upload failed
SecretCrudOnTypeScriptAppHost ❌ Upload failed
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels ▶️ View Recording
StopAllAppHostsFromAppHostDirectory ▶️ View Recording
StopAllAppHostsFromUnrelatedDirectory ▶️ View Recording
StopNonInteractiveMultipleAppHostsShowsError ▶️ View Recording
StopNonInteractiveSingleAppHost ❌ Upload failed
StopWithNoRunningAppHostExitsSuccessfully ▶️ View Recording
TypeScriptAppHostWithProjectReferenceIntegration ▶️ View Recording

📹 Recordings uploaded automatically from CI run #22937599277

@radical radical added the area-engineering-systems infrastructure helix infra engineering repo stuff label Mar 11, 2026
@radical radical merged commit 0b3c5d7 into release/13.2 Mar 11, 2026
499 of 502 checks passed
@radical radical deleted the ankj/deploy-scripts branch March 11, 2026 06:35
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants