Add TypeScript SDK refresh workflow#15299
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15299Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15299" |
|
The transient CI rerun workflow requested reruns for the following jobs after analyzing the failed attempt.
|
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #23200909462 |
There was a problem hiding this comment.
Pull request overview
Adds scheduled automation to keep the checked-in TypeScript polyglot playground AppHost SDKs refreshed and aligned with current CLI/codegen output.
Changes:
- Introduces a GitHub Actions workflow to run the refresh on a schedule or manually, then open/update an automated PR.
- Adds a PowerShell script to locate ValidationAppHost playground apps, run restore + npm install, clear stale
.modules, and validate expected outputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| eng/refreshTypeScriptSdks.ps1 | Implements the SDK refresh logic (discover apps, install deps, run restore, validate generated files). |
| .github/workflows/refresh-typescript-sdks.yml | Schedules/runs the refresh script and creates/updates an automation PR targeting main. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| uses: dotnet/actions-create-pull-request@e8d799aa1f8b17f324f9513832811b0a62f1e0b1 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| branch: update-typescript-playground-sdks |
There was a problem hiding this comment.
Should this be a unique branch name each time? Or at least see if there is already a PR open and update the branch associated with that one, and if not create a new branch for a new PR?
| @@ -0,0 +1,45 @@ | |||
| name: Refresh TypeScript Playground SDKs | |||
There was a problem hiding this comment.
Would it be out of the question to use the existing "manifest" workflow for this? That way we only get 1 PR for all.
https://github.com/dotnet/aspire/blob/main/.github/workflows/refresh-manifests.yml
It would be easier to manage and less to maintain.
There was a problem hiding this comment.
Meh, what about automating the merge with another workflow? I don't want one to break the other ...
There was a problem hiding this comment.
The issue is that now we have 2 PRs that we are going to ignore instead of just one.
| run: | | ||
| ./eng/refreshTypeScriptSdks.ps1 | ||
|
|
||
| - name: Create or update pull request |
There was a problem hiding this comment.
Note that this will break in the microsoft move as you need to add a step to fetch the token differently. I can help fixing it at that point.
* Add TypeScript SDK refresh workflow Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address TypeScript SDK workflow review comments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description
Adds scheduled automation to regenerate the checked-in TypeScript polyglot playground AppHost SDKs so they stay aligned with the current CLI/codegen output.
Summary of changes:
.github/workflows/refresh-typescript-sdks.ymlto run on a schedule or via manual dispatcheng/refreshTypeScriptSdks.ps1to discoverplayground/polyglot/TypeScript/*/ValidationAppHostapps, install npm dependencies, clear stale.modulesoutput, runaspire restore, and verify the generated SDK files existmainValidation performed:
pwshis not installed here; I plan to validate it on another machineFixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: