Skip to content

Fix TypeScript playground samples for polyglot API changes#15336

Merged
mitchdenny merged 1 commit intomicrosoft:release/13.2from
adamint:dev/adamint/fix-ts-samples
Mar 18, 2026
Merged

Fix TypeScript playground samples for polyglot API changes#15336
mitchdenny merged 1 commit intomicrosoft:release/13.2from
adamint:dev/adamint/fix-ts-samples

Conversation

@adamint
Copy link
Member

@adamint adamint commented Mar 17, 2026

Description

Update TypeScript playground samples to respond to polyglot API changes. Replaces withServiceReference calls with withReference in the RpsArena and AzureFunctionsSample AppHost files, and regenerates .modules accordingly.

No follow-up needed.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings March 17, 2026 23:07
@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15336

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15336"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates TypeScript playground AppHost samples and embedded generated SDK modules to align with recent polyglot/TypeScript API and transport changes (including cancellation token handling and argument marshalling). The PR description also references a VS Code extension version bump, but the diff primarily reflects playground/sample regeneration.

Changes:

  • Update RpsArena sample to use .withReference(...) instead of the removed/renamed .withServiceReference(...).
  • Regenerate RpsArena embedded TS transport/base modules to support CancellationToken, toTransportValue() marshalling, circular reference detection, and improved AspireClient connection/cancellation behavior.
  • Regenerate AzureFunctionsSample embedded .modules/aspire.ts output (primarily reordering/reshaping generated APIs).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
playground/TypeScriptApps/RpsArena/apphost.ts Updates sample usage to the new reference API (withReference).
playground/TypeScriptApps/RpsArena/.modules/transport.ts Adds cancellation token support, transport marshalling, circular reference detection, and connection lifecycle changes.
playground/TypeScriptApps/RpsArena/.modules/base.ts Re-exports CancellationToken, updates expression handling, and adds toTransportValue() for collection wrappers.
playground/TypeScriptApps/RpsArena/.modules/.codegen-hash Updates codegen hash for regenerated RpsArena modules.
playground/TypeScriptApps/AzureFunctionsSample/AppHost/.modules/aspire.ts Regenerated TypeScript SDK output (API ordering/shape updates).
playground/TypeScriptApps/AzureFunctionsSample/AppHost/.modules/.codegen-hash Updates codegen hash for regenerated AzureFunctionsSample modules.

You can also share your feedback on Copilot code review. Take the survey.

@mitchdenny mitchdenny enabled auto-merge (squash) March 18, 2026 00:31
@mitchdenny mitchdenny merged commit f338a58 into microsoft:release/13.2 Mar 18, 2026
508 of 512 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Mar 18, 2026
Copilot AI pushed a commit that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants