Fix TypeScript playground samples for polyglot API changes#15336
Merged
mitchdenny merged 1 commit intomicrosoft:release/13.2from Mar 18, 2026
Merged
Fix TypeScript playground samples for polyglot API changes#15336mitchdenny merged 1 commit intomicrosoft:release/13.2from
mitchdenny merged 1 commit intomicrosoft:release/13.2from
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15336Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15336" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates TypeScript playground AppHost samples and embedded generated SDK modules to align with recent polyglot/TypeScript API and transport changes (including cancellation token handling and argument marshalling). The PR description also references a VS Code extension version bump, but the diff primarily reflects playground/sample regeneration.
Changes:
- Update RpsArena sample to use
.withReference(...)instead of the removed/renamed.withServiceReference(...). - Regenerate RpsArena embedded TS transport/base modules to support
CancellationToken,toTransportValue()marshalling, circular reference detection, and improvedAspireClientconnection/cancellation behavior. - Regenerate AzureFunctionsSample embedded
.modules/aspire.tsoutput (primarily reordering/reshaping generated APIs).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| playground/TypeScriptApps/RpsArena/apphost.ts | Updates sample usage to the new reference API (withReference). |
| playground/TypeScriptApps/RpsArena/.modules/transport.ts | Adds cancellation token support, transport marshalling, circular reference detection, and connection lifecycle changes. |
| playground/TypeScriptApps/RpsArena/.modules/base.ts | Re-exports CancellationToken, updates expression handling, and adds toTransportValue() for collection wrappers. |
| playground/TypeScriptApps/RpsArena/.modules/.codegen-hash | Updates codegen hash for regenerated RpsArena modules. |
| playground/TypeScriptApps/AzureFunctionsSample/AppHost/.modules/aspire.ts | Regenerated TypeScript SDK output (API ordering/shape updates). |
| playground/TypeScriptApps/AzureFunctionsSample/AppHost/.modules/.codegen-hash | Updates codegen hash for regenerated AzureFunctionsSample modules. |
You can also share your feedback on Copilot code review. Take the survey.
mitchdenny
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update TypeScript playground samples to respond to polyglot API changes. Replaces
withServiceReferencecalls withwithReferencein the RpsArena and AzureFunctionsSample AppHost files, and regenerates.modulesaccordingly.No follow-up needed.
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: