Add test for PostgresServerResource.WithInitBindMount#4926
Merged
sebastienros merged 8 commits intomainfrom Jul 18, 2024
Merged
Add test for PostgresServerResource.WithInitBindMount#4926sebastienros merged 8 commits intomainfrom
sebastienros merged 8 commits intomainfrom
Conversation
eerhardt
approved these changes
Jul 16, 2024
Member
eerhardt
left a comment
There was a problem hiding this comment.
Looks good. Just some minor tweaks.
tests/Aspire.Hosting.PostgreSQL.Tests/PostgresFunctionalTests.cs
Outdated
Show resolved
Hide resolved
tests/Aspire.Hosting.PostgreSQL.Tests/PostgresFunctionalTests.cs
Outdated
Show resolved
Hide resolved
tests/Aspire.Hosting.PostgreSQL.Tests/PostgresFunctionalTests.cs
Outdated
Show resolved
Hide resolved
mitchdenny
approved these changes
Jul 17, 2024
radical
reviewed
Jul 17, 2024
| command.CommandText = $"SELECT * FROM cars;"; | ||
| var results = await command.ExecuteReaderAsync(token); | ||
|
|
||
| Assert.Single(results); |
Member
There was a problem hiding this comment.
Would it be useful to assert the contents of the result too?
Member
|
Test failing with: And the log has this: |
Contributor
Author
|
@radical do you know if there is a way to get the Docker logs for the failure? I want to see if there is an issue during the initialization of the image, since we are passing a custom bind mount and the DCP errors seems to indicate that the container hasn't started for this test only. |
Contributor
Author
|
Worked like a charm, so I know what's happening now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized it was missing when I extracted MySql which has the same one.
Microsoft Reviewers: Open in CodeFlow