Clear log messages when disposed#4957
Merged
adamint merged 3 commits intomicrosoft:mainfrom Jul 19, 2024
Merged
Conversation
Fixes microsoft#4954, preventing duplicated log messages from appearing when navigating back to the previously displayed log. Also encapsulate management of the base line number within the `LogEntries` class, and clear it along with log entries to ensure state doesn't leak between logs.
drewnoakes
force-pushed
the
dev/drnoakes/fix-duplicate-logs
branch
from
775779b to
e4dafe3
Compare
JamesNK
reviewed
Jul 18, 2024
adamint
approved these changes
Jul 18, 2024
Member
|
Flaky tests failing again... |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Different failed tests now, still flaky (unrelated to these changes) |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
1 task
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4954, preventing duplicated log messages from appearing when navigating back to the previously displayed log.
Also encapsulate management of the base line number within the
LogEntriesclass, and clear it along with log entries to ensure state doesn't leak between logs.Microsoft Reviewers: Open in CodeFlow