Skip to content

[tests] Clear docker volumes on helix#5064

Merged
eerhardt merged 7 commits intomicrosoft:mainfrom
radical:clear-docker-vols
Jul 29, 2024
Merged

[tests] Clear docker volumes on helix#5064
eerhardt merged 7 commits intomicrosoft:mainfrom
radical:clear-docker-vols

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Jul 24, 2024

Microsoft Reviewers: Open in CodeFlow

@radical radical requested a review from eerhardt as a code owner July 24, 2024 22:49
@ghost ghost added the area-engineering-systems infrastructure helix infra engineering repo stuff label Jul 24, 2024
@radical
Copy link
Copy Markdown
Member Author

radical commented Jul 24, 2024

This is needed on the build machine too, but I'm not sure if that's OK to do!

@radical radical requested a review from joperezr July 24, 2024 22:55
<HelixPostCommand Condition="'$(HasDocker)' == 'true'" Include="docker container ls --all" />
<HelixPostCommand Condition="'$(HasDocker)' == 'true'" Include="$(_ShutdownDockerContainersCommand)" />
<HelixPostCommand Condition="'$(HasDocker)' == 'true'" Include="docker volume ls" />
<HelixPostCommand Condition="'$(HasDocker)' == 'true'" Include="$(_DeleteDockerVolumesCommand)" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this twice?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre, and post tests run.

Playwright dependencies have been installed on the helix image.

Issue: microsoft#4623
@radical
Copy link
Copy Markdown
Member Author

radical commented Jul 24, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical requested a review from eerhardt July 25, 2024 17:29
@eerhardt eerhardt merged commit 25ef48d into microsoft:main Jul 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants