Skip to content

Only run npm if required #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radical merged 1 commit into from
Aug 20, 2024
Merged

Only run npm if required #5363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playground/BrowserTelemetry/BrowserTelemetry.Web/BrowserTelemetry.Web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
2. Run npm run build before building the .NET project.
MSBuild runs NpmInstall before this task because of the DependsOnTargets attribute.
-->
<Target Name="NpmRunBuild" DependsOnTargets="NpmInstall" BeforeTargets="BeforeBuild" Condition="'$(Configuration)' == 'Debug' and '$(NpmUnavailable)' != 'true' ">
<Target Name="NpmRunBuild" DependsOnTargets="NpmInstall" Condition="'$(Configuration)' == 'Debug' and '$(NpmUnavailable)' != 'true' ">
<Exec Command="npm run build" />
</Target>

Expand Down
10 changes: 10 additions & 0 deletions playground/BrowserTelemetry/BrowserTelemetry.Web/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Updating web assets

When changes to the `./package.json` or `./Scripts/index.js` are made the `./wwwwroot/scripts/bundle.js` file needs to be updated by running the following command:

```console
dotnet build /t:NpmRunBuild
```

This will install the required npm packages and run the webpack command generating this file.
Note that the `package-lock.json`