Fix flaky test and add more test logging#6366
Merged
Conversation
JamesNK
added
the
area-app-model
JamesNK
changed the title
16 tasks
JamesNK
commented
Oct 18, 2024
mitchdenny
approved these changes
Oct 18, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Test failure seemed unrelated, re-running. |
JamesNK
force-pushed
the
jamesnk/hosting-test-logging
branch
from
e68aa4e to
52f1a31
Compare
eerhardt
reviewed
Oct 18, 2024
| return task.AsTask().TimeoutAfter(timeout, filePath, lineNumber); | ||
| } | ||
|
|
||
| [SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Required to maintain compatibility")] |
Member
There was a problem hiding this comment.
- Do we have public analyzers turned on for our tests? That seems wrong.
- What does
"Required to maintain compatibility"mean for our tests? I don't think we need to worry about compatibility.
Member
Author
There was a problem hiding this comment.
It’s copied from dotnet/aspnetcore
Member
There was a problem hiding this comment.
It would be good to add that in a comment on the file
eerhardt
reviewed
Oct 18, 2024
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace Microsoft.AspNetCore.InternalTesting; |
Member
There was a problem hiding this comment.
Is this the right namespace to use?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds more logging to tests.
Also improve flaky test to avoid potential race condition.
Fixes #6354
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow