Skip to content

Enable metric exemplars by default in Aspire 9.0 templates#7260

Merged
davidfowl merged 1 commit intomicrosoft:mainfrom
matthebrown:EnableMetricExemplars2
Jan 27, 2025
Merged

Enable metric exemplars by default in Aspire 9.0 templates#7260
davidfowl merged 1 commit intomicrosoft:mainfrom
matthebrown:EnableMetricExemplars2

Conversation

@matthebrown
Copy link
Copy Markdown
Contributor

@matthebrown matthebrown commented Jan 27, 2025

Description

My previous changes only enable metric exemplars for the playground apps. This set of changes updates the 9.0 Aspire templates to enable metric exemplars by default.

Fixes #4839

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 27, 2025
@matthebrown matthebrown changed the title Enable metric exemplars in Aspire 9.0 templates Enable metric exemplars by default in Aspire 9.0 templates Jan 27, 2025
@davidfowl davidfowl merged commit 706bbbf into microsoft:main Jan 27, 2025
@davidfowl
Copy link
Copy Markdown
Contributor

Thanks!

@matthebrown matthebrown deleted the EnableMetricExemplars2 branch January 27, 2025 04:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-templates community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update templates' service defaults to enable metric exemplars

2 participants