Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- eng/Versions.props: Language not supported
- src/Aspire.ProjectTemplates/cgmanifest.json: Language not supported
- src/Aspire.ProjectTemplates/templates/aspire-starter/8.2/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj: Language not supported
- src/Aspire.ProjectTemplates/templates/aspire-starter/9.0/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj: Language not supported
- src/Aspire.ProjectTemplates/templates/aspire-starter/9.1/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj: Language not supported
|
also does the build automatically check the template projects succcessfully restore or do I do that manually? |
| <PackageReference Include="coverlet.collector" Version="6.0.2" Condition=" $(TestFramework) == 'xUnit.net' " /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" Condition=" $(TestFramework) != 'MSTest' " /> | ||
| <PackageReference Include="MSTest" Version="3.4.3" Condition=" $(TestFramework) == 'MSTest' " /> | ||
| <PackageReference Include="MSTest" Version="3.6.1" Condition=" $(TestFramework) == 'MSTest' " /> |
There was a problem hiding this comment.
This is the unsupported template (8.2), we don't update these.
There was a problem hiding this comment.
do we want to delete the 8.x templates yet?
...spire-starter/9.0/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj
Show resolved
Hide resolved
...spire-starter/9.1/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj
Outdated
Show resolved
Hide resolved
...spire-starter/9.1/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj
Show resolved
Hide resolved
|
OK I think good now |
|
As discussed offline, this is guaranteed to get out of date/wrong. But for a moment, it is not |
DamianEdwards
left a comment
There was a problem hiding this comment.
Looks good. Do we have a plan to automate this somehow, at least failing when it gets out o date?
|
No, we don't. Thread continues on that |
That was the initial plan, but we decided to update this file manually as part of the checklist before shipping. I assume "when" we decide it's worth spending the time on it. There might be some things that are hard to do automatically (multi targeting templates and versions.props, ...) |
|
chatted offline and @wtgodbe will at least make a script that does something like
that's not necessarily in the build but much better than doing it by hand. and it should be enough for dotnet/sdk as well |
Description
Update cgmanifest.json. Where I saw we had inconsistent versions, I updated the templates to latest -- @DamianEdwards let me know if this is in fact not appropriate.
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):