Implement publisher advertisement and CLI integration#8224
Merged
mitchdenny merged 13 commits intoMar 22, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements publisher advertisement events and enhances CLI integration by adding new publisher-related functionality, updating the backchannel connection, and adjusting Azure provisioning modes. Key changes include:
- Adding new tests and publisher advertisement events to support publisher discovery.
- Updating backchannel and CLI components to enable fetching publishers via RPC calls.
- Adjusting execution mode checks in Azure infrastructure and provisioners.
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/Backchannel/AppHostBackchannelTests.cs | Introduces tests for backchannel connectivity, ping responses, resource streaming, and publisher requests. |
| src/Aspire.Hosting/Publishing/PublisherAdvertisementEvent.cs | Implements publisher advertisement event and related types. |
| src/Aspire.Cli/Program.cs | Adds CLI integration for retrieving publishers asynchronously. |
| src/Aspire.Hosting/Backchannel/AppHostRpcTarget.cs | Updates to include a new GetPublishersAsync method using publisher advertisement events. |
| src/Aspire.Cli/Backchannel/AppHostBackchannel.cs | Adds IDisposable support and integrates process management for backchannel connections. |
| src/Aspire.Hosting/PublisherDistributedApplicationBuilderExtensions.cs | Subscribes to publisher advertisement events when adding a publisher. |
| src/Aspire.Hosting.Azure.* | Adjusts execution mode conditions in Azure infrastructure and provisioners. |
| playground/publishers/Publishers.AppHost/docker-compose.yaml | Updates connection string for SQL Server configuration. |
| src/Aspire.Hosting.Azure/AzureResourcePreparer.cs | Skips Azure resource preparation in inspect mode. |
| src/Aspire.Cli/DotNetCliRunner.cs | Updates backchannel connection startup to include process information. |
Files not reviewed (1)
- playground/publishers/Publishers.AppHost/Properties/launchSettings.json: Language not supported
davidfowl
reviewed
Mar 21, 2025
Co-authored-by: David Fowler <davidfowl@gmail.com>
davidfowl
reviewed
Mar 21, 2025
davidfowl
reviewed
Mar 21, 2025
davidfowl
reviewed
Mar 21, 2025
Contributor
|
Conflcits! |
Contributor
|
Fit n finish things either for this PR or a follow up issue -
|
davidfowl
reviewed
Mar 22, 2025
davidfowl
approved these changes
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce publisher advertisement events and enhance CLI functionality to retrieve publishers. Update the application to handle different execution modes and improve backchannel connection handling.
We now fire an event when the CLI asks the AppHost for publishers to advertise themselves. This is currently hooked up inside the
AddPublishermethod, and this will probably be where publishers declare the arguments that they accept and their mapping to options.At the moment the
GetPublishersAsyncRPC call just returns an array of strings but once I start working on option mapping it will be a richer set of objects that are returned.aspire-build-prompting.mp4