Skip to content

Fixing pull request update action and exclusion logic for api Review#8385

Merged
joperezr merged 2 commits intomicrosoft:mainfrom
joperezr:FixGHAPRs
Mar 28, 2025
Merged

Fixing pull request update action and exclusion logic for api Review#8385
joperezr merged 2 commits intomicrosoft:mainfrom
joperezr:FixGHAPRs

Conversation

@joperezr
Copy link
Copy Markdown
Member

cc: @eerhardt @danmoseley @radical

This fixes:

  • Pull requests failing the action when updating an existing pull request by using a patched version of the action
  • Corrected the logic of excluding multiple projects so API generation is skipped for them correctly.

Copilot AI review requested due to automatic review settings March 28, 2025 20:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes issues with the pull request update action and refines the exclusion logic for API generation to skip specific projects.

  • Updates the pull request creation action version to a pinned commit hash.
  • Refactors the csproj file exclusion logic in the API diffs workflow for better accuracy.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/update-dependencies.yml Updates the action reference for creating pull requests to use a specific commit hash.
.github/workflows/generate-api-diffs.yml Refines the exclusion logic to filter out specific project paths during API generation.

@github-actions github-actions Bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Mar 28, 2025
Comment thread .github/workflows/generate-api-diffs.yml Outdated
@radical
Copy link
Copy Markdown
Member

radical commented Mar 28, 2025

.. patched version of the action

Could you please reference the issue for this patched version?

Co-authored-by: Ankit Jain <radical@gmail.com>
Copy link
Copy Markdown
Member Author

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. patched version of the action

Could you please reference the issue for this patched version?

Of course, The original bug we were hitting during an update of a PR was peter-evans/create-pull-request#2790, which was fixed by peter-evans/create-pull-request#2792 in the main fork. I created PR dotnet/actions-create-pull-request#47 on the dotnet fork which is the version that I'm updating this PR to point to.

@joperezr joperezr enabled auto-merge (squash) March 28, 2025 20:27
@joperezr joperezr merged commit b944935 into microsoft:main Mar 28, 2025
168 checks passed
@joperezr joperezr deleted the FixGHAPRs branch April 1, 2025 17:43
@github-actions github-actions Bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow. intentionally a different color!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants