Update hardcoded name in playwright test#8680
Merged
danmoseley merged 1 commit intomicrosoft:mainfrom Apr 9, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs:59
- The test is no longer skipped. Please confirm that this change is intentional and that the test is stable in your CI environment.
[Fact]
tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs:81
- Ensure that Login.InvalidTokenErrorMessage is defined in Aspire.Dashboard.Resources and returns the expected localized error message.
.Expect(page.GetByText(Login.InvalidTokenErrorMessage))
Member
Author
|
Failing test is unrelated. |
radical
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"Invalid token" was the only hardcoded string in
GetByTextin this class will cause a timeout error on non-EN cultures. Is something about the GH runner culture messed up? I know we had format tests fail before...Seems to fix #7522
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):