feat(localization): initial how to fix fixes #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoslund
reviewed
Oct 27, 2022
Member
sfoslund
left a comment
sfoslund
left a comment
There was a problem hiding this comment.
These look good to me, but I think @ferBonnin should be the one to give final approval
ferBonnin
reviewed
Oct 27, 2022
sfoslund
reviewed
Oct 27, 2022
1 task
ferBonnin
reviewed
Oct 27, 2022
DaveTryon
reviewed
Oct 31, 2022
DaveTryon
reviewed
Oct 31, 2022
DaveTryon
reviewed
Oct 31, 2022
DaveTryon
reviewed
Oct 31, 2022
DaveTryon
reviewed
Oct 31, 2022
Codecov Report
@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 73.70% 74.73% +1.03%
==========================================
Files 398 421 +23
Lines 12046 12983 +937
==========================================
+ Hits 8878 9703 +825
- Misses 3168 3280 +112
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sfoslund
approved these changes
Oct 31, 2022
DaveTryon
approved these changes
Oct 31, 2022
Contributor
Author
|
@ferBonnin accepted these changes offline. Merging. |
sfoslund
added a commit
that referenced
this pull request
Oct 31, 2022
#### Details Sister PR to #790 this PR covers the how to fix strings that are still outstanding after those changes. I don't have much context on most of these, so please feel free to correct or expand on any of these strings! ##### Motivation Localization feature #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: [2002610](https://dev.azure.com/mseng/1ES/_workitems/edit/2002610) Co-authored-by: Dave Tryon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds more meaningful "how to fix" text for some rules in place of just repeating the description.
Motivation
Part of localization feature (internal access required to view).
Context
Remaining rules to follow, these are just the ones that I felt confident fixing.
Pull request checklist