Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Fix CodeQL alert SM01507: Client-side URL redirect#6538

Merged
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/SM01507-alert
Nov 3, 2022
Merged

Fix CodeQL alert SM01507: Client-side URL redirect#6538
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/SM01507-alert

Conversation

@ceciliaavila
Copy link
Copy Markdown
Collaborator

Fixes #6537 #6521 #6514 #6500 #6499 #6498 #6497 #6496 #6495 #6494 #6493 #6492 #6491 #6490 #6489 #6488 #6486

Description

This PR fixes de CodeQL SM01507 alert related to open redirects by implementing a fixed domain for the script's src param.

Specific Changes

  • Updated build/AnalyzeDeps/InterdependencyGraph.html to append the domain URL to the data param.

Testing

We tested the changes locally rendering the HTML with and without the data query parameter.
image

@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 327818

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.009%) to 79.015%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs 1 90.0%
Totals Coverage Status
Change from base Build 327679: -0.009%
Covered Lines: 25597
Relevant Lines: 32395

💛 - Coveralls

This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

3 participants