Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6512] CodeQL alert SM00431: Information exposure through an exception#6544

Merged
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/setbody-exception
Nov 11, 2022
Merged

[#6512] CodeQL alert SM00431: Information exposure through an exception#6544
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/setbody-exception

Conversation

@sw-joelmut
Copy link
Copy Markdown
Collaborator

Fixes #6512

Description

This PR fixes the CodeQL SM00431 alert related to exposing an exception to the end user (more information).

Specific Changes

  • Updates response SetBody parameter usage, changing from the whole exception to just the message.

Testing

The following image shows the before and after the applied fix, using the CodeQL query tool.
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner November 9, 2022 13:06
@tracyboehrer tracyboehrer added the Automation: No parity PR does not need to be applied to other languages. label Nov 10, 2022
@tracyboehrer
Copy link
Copy Markdown
Member

This is approved, but can't be merged until we correct a compliance issue. This is why the build is failing.

@tracyboehrer tracyboehrer merged commit 746c02f into main Nov 11, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/setbody-exception branch November 11, 2022 19:56
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CodeQL alert SM00431: Information exposure through an exception in microsoft/microsoft/botbuilder-dotnet/botbuilder-dotnet

2 participants