Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Fix cast issue in SendHandoffActivity action#6575

Merged
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/cast-issue-handoff
Jan 13, 2023
Merged

Fix cast issue in SendHandoffActivity action#6575
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/cast-issue-handoff

Conversation

@ceciliaavila
Copy link
Copy Markdown
Collaborator

@ceciliaavila ceciliaavila commented Jan 13, 2023

#minor

Description

This PR fixes the casting error found in the Telephony unit tests when the handoff context is an object.

Specific Changes

  • Updated BeginDialogAsync method in SendHandoffActivity class replacing the JObject cast with the JObject.FromObject parse method.

Testing

These images show the Telephony tests working after the fix and the Dialogs.Adaptive tests passing:
image
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Jan 13, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner January 13, 2023 19:35
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jan 13, 2023

Pull Request Test Coverage Report for Build 336829

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.02%) to 73.28%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableDate.cs 1 93.94%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableDate.cs 1 93.94%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Connector.Streaming/Application/TimerAwaitable.cs 1 68.25%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 2 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 2 90.91%
Totals Coverage Status
Change from base Build 334351: -0.02%
Covered Lines: 23920
Relevant Lines: 32642
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 7fbb30a into main Jan 13, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/cast-issue-handoff branch January 13, 2023 20:12
tracyboehrer pushed a commit that referenced this pull request Jan 17, 2023
@ceciliaavila
Fix cast issue in SendHandoffActivity action. (#6575)
2b19d77
tracyboehrer added a commit that referenced this pull request Jan 17, 2023
@tracyboehrer @ceciliaavila
@erquirogasw @sw-joelmut
4.19.1 Patch (#6578)
dcaa545 
* Fix cast issue in SendHandoffActivity action. (#6575)

* [#6563] Expired JWT token exception not being handled (#6572)

* Add UnauthorizedAccessException when the SecurityTokenExpiredException is thrown

* Add CloudAdapter test

Co-authored-by: sw-joelmut <joel.mut@southworks.com>

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
Co-authored-by: erquirogasw <64815358+erquirogasw@users.noreply.github.com>
Co-authored-by: sw-joelmut <joel.mut@southworks.com>
@dependabot dependabot Bot mentioned this pull request Dec 21, 2025
Merged
This was referenced May 14, 2026
Closed
Closed
Closed
Open
Closed
Closed
Open
Closed
Closed
Open
Closed
Open
Closed
Closed
Closed
Open
Open
Open
Open
Open
This was referenced May 14, 2026
Open
Open
Open
Open
Closed
Open
Closed
Closed
Closed
Closed
Open
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ceciliaavila @coveralls @tracyboehrer