Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Fix class structure for meeting notification feature extensibility#6579

Merged
tracyboehrer merged 4 commits into
mainfrom
yingdu/fixClass
Feb 10, 2023
Merged

Fix class structure for meeting notification feature extensibility#6579
tracyboehrer merged 4 commits into
mainfrom
yingdu/fixClass

Conversation

@yingduyingdu
Copy link
Copy Markdown
Contributor

@yingduyingdu yingduyingdu commented Jan 19, 2023

Fixes #6580

Description

This PR fixes the extensibility issue for the Teams bot meeting notification feature by updating on model classes.

Specific Changes

Update classes to support different types of meeting notification, surface type, and content type.
Update reference and unit tests.

Testing

Update and pass unit tests.
Pass manual testing via personal test bot.

@yingduyingdu yingduyingdu force-pushed the yingdu/fixClass branch 5 times, most recently from 2779c8c to 6ab06ca Compare January 23, 2023 21:16
@yingduyingdu yingduyingdu marked this pull request as ready for review January 23, 2023 21:17
@yingduyingdu yingduyingdu requested a review from a team as a code owner January 23, 2023 21:17
Comment thread libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotification.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/NotificationRecipientFailureInfo.cs Outdated
Copy link
Copy Markdown

@YunnyChung YunnyChung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR review :)

Comment thread libraries/Microsoft.Bot.Builder/Teams/TeamsInfo.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/SurfaceType.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Converters/SurfaceConverter.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Converters/SurfaceConverter.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotification.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotificationChannelData.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/Surface.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotificationChannelData.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/Surface.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/TargetedMeetingNotificationValue.cs Outdated
Copy link
Copy Markdown

@YunnyChung YunnyChung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comment for my own learning :)

Comment thread libraries/Microsoft.Bot.Connector/Teams/TeamsOperationsExtensions.cs Outdated
@yingduyingdu yingduyingdu force-pushed the yingdu/fixClass branch 2 times, most recently from 66bbed4 to c7e4058 Compare January 26, 2023 05:15
@microsoft microsoft deleted a comment from coveralls Jan 26, 2023
Comment thread libraries/Microsoft.Bot.Builder/Teams/TeamsInfo.cs Outdated
Comment thread libraries/Microsoft.Bot.Builder/Teams/TeamsInfo.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotificationChannelData.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/MeetingNotificationResponse.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/MeetingNotificationResponse.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/NotificationRecipientFailureInfo.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/TargetedMeetingNotification.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Converters/SurfaceConverter.cs
Copy link
Copy Markdown

@YunnyChung YunnyChung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few follow ups

Comment thread libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotificationChannelData.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/MeetingStageSurface.cs
Comment thread libraries/Microsoft.Bot.Schema/Teams/NotificationRecipientFailureInfo.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/TargetedMeetingNotificationValue.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/TargetedMeetingNotification.cs Outdated
@yingduyingdu yingduyingdu requested review from YunnyChung, singhk97 and vule-msft and removed request for YunnyChung and vule-msft January 30, 2023 21:14
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix class structure for teams bot meeting notification to resolve breaking change when extending surface type

6 participants