This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#6591] Concurrency issue with TimeZoneConverter#6593
Merged
tracyboehrer merged 2 commits intoFeb 23, 2023
Conversation
Collaborator
Author
|
Hi @tracyboehrer, this is the fix for the concurrency issue. |
Collaborator
Pull Request Test Coverage Report for Build 341679
💛 - Coveralls |
johnataylor
approved these changes
Feb 23, 2023
Member
|
|
tracyboehrer
pushed a commit
that referenced
this pull request
Feb 23, 2023
* Use ConcurrentDictionary in TimeZoneConverter * Add static constructor
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6591
Description
This PR fixes the concurrency issue in the TimeZoneConverter class by changing the Dictionaries to be thread-safe and also adding a static constructor to the class to execute the LoadData method only once.
Specific Changes
Testing
Here we can see concurrent tests failing before the changes and the same tests passing after the changes.
