This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#6624] port: [#4452][#4456][#4460][botframework-streaming] Should reject pending requests on disconnection#6627
Merged
tracyboehrer merged 1 commit intoMay 8, 2023
Conversation
Collaborator
Pull Request Test Coverage Report for Build 349985
💛 - Coveralls |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll |
tracyboehrer
approved these changes
May 8, 2023
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6624
Description
This PR ports the changes from PR#4461 to reject all pending requests when the websocket is disconnected.
Specific Changes
RejectAllResponsesmethod in RequestManager class.RejectAllResponsesin OnConnectionDisconnected of WebSocketClient.Utilitiesfolder for reuse by the test classes.Testing
These images show the pending requests being rejected after the fix and the new unit tests passing.
