Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#5820] Outgoing Activity Locale being Overwritten#6629

Merged
tracyboehrer merged 1 commit into
mainfrom
southworks/update/outgoing-activity-locale
May 8, 2023
Merged

[#5820] Outgoing Activity Locale being Overwritten#6629
tracyboehrer merged 1 commit into
mainfrom
southworks/update/outgoing-activity-locale

Conversation

@ceciliaavila
Copy link
Copy Markdown
Collaborator

Fixes #5820

Description

This PR updates the Activity's ApplyConversationReference method to prioritize the activity's locale over the reference locale.

Specific Changes

  • Updated ApplyConversationReference method in ActivityEx class to use the activity's locale first. If it's null, use the reference's locale.
  • Updated unit tests to assert the right locale values.

Testing

These images show the overridden locale property (before) and how it's kept after the changes.

BEFORE:
image

AFTER:
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label May 5, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner May 5, 2023 17:14
@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 350384

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.093%

Totals Coverage Status
Change from base Build 349053: 0.0%
Covered Lines: 25827
Relevant Lines: 32654

💛 - Coveralls

@BruceHaley
Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@tracyboehrer tracyboehrer merged commit 2e9044d into main May 8, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/outgoing-activity-locale branch May 8, 2023 19:42
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outgoing Activity Locale being Overwritten

4 participants