This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#6628] port [#4449] CloudAdapter always builds Connector with MicrosoftAppCredentials (never CertificateAppCredentials) -- certificate auth flow broken#6631
Merged
Conversation
Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
Collaborator
Pull Request Test Coverage Report for Build 351865
💛 - Coveralls |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll |
tracyboehrer
approved these changes
May 16, 2023
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6628
Description
This PR add the
CertificateServiceClientCredentialsFactoryclass to allow bot authentication with a certificate.Specific Changes
CertificateServiceClientCredentialsFactoryclass to instantiate and use theCertificateAppCredentials.CertificateServiceClientCredentialsFactoryTestsclass with all the unit tests for the methods.Testing
The following image shows the changes working as expected.
