Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Resolve concurrency issues in InterfaceConverter's ReadJson method#6681

Merged
tracyboehrer merged 1 commit into
mainfrom
fix-thread-safety-issues
Aug 10, 2023
Merged

Resolve concurrency issues in InterfaceConverter's ReadJson method#6681
tracyboehrer merged 1 commit into
mainfrom
fix-thread-safety-issues

Conversation

@ram-xv
Copy link
Copy Markdown
Contributor

@ram-xv ram-xv commented Aug 10, 2023

#minor
Closes IcM: https://portal.microsofticm.com/imp/v3/incidents/details/403753372/home

Description

This PR addresses concurrency issues observed in the InterfaceConverter's ReadJson method. The changes ensure thread-safe operations when deserializing JSON concurrently.

Specific Changes

  • Replaced Dictionary<string, T> type declarations with ConcurrentDictionary<string, T> for rangeReferences, cachedRefDialogs and cachedTypes.

Resolve concurrency issues in InterfaceConverter's ReadJson method
@ram-xv ram-xv requested a review from a team as a code owner August 10, 2023 04:15
@ram-xv ram-xv requested a review from tracyboehrer August 10, 2023 04:16
@ram-xv ram-xv added the Automation: No parity PR does not need to be applied to other languages. label Aug 10, 2023
@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 363742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.03%) to 78.956%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableDate.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableDate.cs 1 93.94%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Connector.Streaming/Transport/TransportHandler.cs 2 96.39%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 6 89.62%
/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Converters/InterfaceConverter.cs 10 81.16%
Totals Coverage Status
Change from base Build 362013: -0.03%
Covered Lines: 25937
Relevant Lines: 32850

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit fdaed8b into main Aug 10, 2023
@tracyboehrer tracyboehrer deleted the fix-thread-safety-issues branch August 10, 2023 16:56
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants