Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6651] Replace TestFramework package to remove ADAL dependencies#6690

Merged
tracyboehrer merged 1 commit into
mainfrom
southworks/update/remove-testframework-package
Sep 18, 2023
Merged

[#6651] Replace TestFramework package to remove ADAL dependencies#6690
tracyboehrer merged 1 commit into
mainfrom
southworks/update/remove-testframework-package

Conversation

@ceciliaavila
Copy link
Copy Markdown
Collaborator

Fixes #6651

Description

This PR replaces the use of Microsoft.Rest.ClientRuntime.Azure.TestFramework to avoid ADAL dependencies.

Specific Changes

  • Added MockContext class in Microsoft.Bot.Connector.Tests to be used by the BaseTest class.
  • Added Microsoft.Azure.Test.HttpRecorder package to use it in the MockContext class.
  • Added ResourceGroupCleaner class in Microsoft.Bot.Connector.Tests.

Testing

The following image shows the Microsoft.Bot.Connector tests passing after the changes.
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Sep 18, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner September 18, 2023 14:20
@tracyboehrer tracyboehrer merged commit 946f9d4 into main Sep 18, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/remove-testframework-package branch September 18, 2023 15:00
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify no ADAL dependencies

3 participants