This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Consistent label and narration for report file name field#783
Merged
chlowell merged 1 commit intomicrosoft:devfrom Jul 11, 2019
chlowell:default-report-filename-narration
Merged
Consistent label and narration for report file name field#783chlowell merged 1 commit intomicrosoft:devfrom chlowell:default-report-filename-narration
chlowell merged 1 commit intomicrosoft:devfrom
chlowell:default-report-filename-narration
Conversation
Member
|
Haha - I'm adding an option and was wondering about that :) |
marklio
approved these changes
Jul 10, 2019
Lxiamail
approved these changes
Jul 10, 2019
| KeyboardNavigation.TabIndex="0" | ||
| Grid.Column="4" Grid.Row="0" /> | ||
| <TextBlock Text="{x:Static const:LocalizedStrings.DefaultFileName}" | ||
| <TextBlock Text="{x:Static const:LocalizedStrings.DefaultReportFilename}" |
Contributor
There was a problem hiding this comment.
nitpick, DefaultReportFilename has value as "Default report file name". "report" is not consistent with the "output" in the "default output directory" control right above it. In addition, in apiport help text, -o and -f help used term "output" instead of "report". This change will make they are not consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The label and automation name for the default report file name field of the settings control don't match, causing screen readers to describe the field inconsistently with its label. This makes both the label and the automation name "Default report file name".