Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Add titles and labels to HTML tables #792

Merged
Lxiamail merged 4 commits into from
Aug 20, 2019
Merged

Add titles and labels to HTML tables #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cde6ec1
ensure tables have titles or aria labels
chlowell Jul 31, 2019
167a74b
caption tables
chlowell Aug 5, 2019
f68282d
PortabilitySummaryPageTitle -> PortabilitySummary
chlowell Aug 5, 2019
fb497fb
caption unresolved assembly tables with 'missing assemblies'
chlowell Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/lib/Microsoft.Fx.Portability.Reports.Html/Resources/LocalizedStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/lib/Microsoft.Fx.Portability.Reports.Html/Resources/LocalizedStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
<data name="PackageIdHeader" xml:space="preserve">
<value>PackageId</value>
</data>
<data name="PortabilitySummaryPageTitle" xml:space="preserve">
<data name="PortabilitySummary" xml:space="preserve">
<value>Portability Summary</value>
</data>
<data name="RecommendedChanges" xml:space="preserve">
Expand Down Expand Up @@ -304,4 +304,7 @@
<data name="Version" xml:space="preserve">
<value>Version</value>
</data>
<data name="PortabilityDetails" xml:space="preserve">
<value>Portability Details</value>
</data>
</root>
2 changes: 1 addition & 1 deletion src/lib/Microsoft.Fx.Portability.Reports.Html/Views/ReportTemplate.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
@if (includePortabilityReport)
{
<li>
<span class="tocItem"><a href="#@LocalizedStrings.PortabilitySummaryPageTitle">@LocalizedStrings.PortabilitySummaryPageTitle</a></span>
<span class="tocItem"><a href="#@LocalizedStrings.PortabilitySummary">@LocalizedStrings.PortabilitySummary</a></span>
</li>
}
</ul>
Expand Down
4 changes: 2 additions & 2 deletions src/lib/Microsoft.Fx.Portability.Reports.Html/Views/_BreakingChangesReport.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

<h2 id="@LocalizedStrings.CompatibilityPageTitle" tabindex="0">@LocalizedStrings.CompatibilityPageTitle</h2>
<div id="summary-compat-byassembly">
<h3 class="compat-subheader">@LocalizedStrings.PerAssemblyOverview</h3>
<table>
<caption class="compat-subheader">@LocalizedStrings.PerAssemblyOverview</caption>
<tbody>
<tr>
<th rowspan="2">@LocalizedStrings.AssemblyHeader</th>
Expand Down Expand Up @@ -81,8 +81,8 @@
@if (Model.OrderedBreakingChangeSkippedAssemblies.Count() > 0)
{
<div id="summary-compat-skippedassemblies">
<h3 class="compat-subheader">@LocalizedStrings.IgnoredAssemblies</h3>
<table>
<caption class="compat-subheader">@LocalizedStrings.IgnoredAssemblies</caption>
<tr>
<th>@LocalizedStrings.Assembly</th>
</tr>
Expand Down
1 change: 1 addition & 0 deletions src/lib/Microsoft.Fx.Portability.Reports.Html/Views/_CompatibilityResults.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
@if (Model.Breaks.Count() > 0)
{
<table>
<caption>@Model.Name</caption>
<thead>
<tr>
<th colspan="4"></th>
Expand Down
11 changes: 7 additions & 4 deletions src/lib/Microsoft.Fx.Portability.Reports.Html/Views/_PortabilityReport.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
<image id="icon-unsupported" width="18px" height="18px" href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABQElEQVR4XqWTvUoEQRCE6wYPZUA80AfwAQz23uCMjA7MDRQEIzPBVEyNTQUFIw00vcQTTMzuAh/AxEQQT8HF/3G/oGGnEUGuoNnd6qoZuqltyKEsyzVJq5I6rnUp6SjGeGhESikzzlc1eL7opfuVbrqbU1Zw9NCgtQMaZpY0eNnaaL2fHusvTK5vKu7sjSS1Y4y3QUA6K3e3Mau5UFDyMP7tYF9o8cAHZv68vipoIJg971PZIZ5HiwdvYGGvFVFHmGmZ2MxwmQYPXubPl9Up0tfoMQGetXd6mRbvhBw+boZ6WF7Mbv1+GsHRk0fQmPAH1GfmZirbCfDJ61tw3Px8/8pZsPAG4jlVhcPgZ7adwNWBB68lkRQWFiTgFlbnLY3DGGM7izIJIyT/jjIvEJw6fdJTc6krDzh6aMwMP9bvDH4ADSsa9uSWVJkAAAAASUVORK5CYII="></image>
</svg>

<h2 id="@LocalizedStrings.PortabilitySummaryPageTitle" tabindex="0">@LocalizedStrings.PortabilitySummaryPageTitle</h2>
<table>
<table id="@LocalizedStrings.PortabilitySummary">
<caption>@LocalizedStrings.PortabilitySummary</caption>
<tbody>
<tr>
<th>@LocalizedStrings.AssemblyHeader</th>
Expand Down Expand Up @@ -115,6 +115,7 @@
if (usedUnresolvedAssembly.Count > 0)
{
<table>
<caption>@LocalizedStrings.MissingAssemblies</caption>
<tbody>
<tr><th>@LocalizedStrings.MissingAssemblies</th></tr>
@foreach (var name in usedUnresolvedAssembly)
Expand All @@ -127,6 +128,7 @@
}

<table class="table_portability_details">
<caption>@LocalizedStrings.PortabilityDetails</caption>
<tbody>
<tr>
@foreach (var header in detailColumnHeaders)
Expand Down Expand Up @@ -171,7 +173,7 @@
</table>

<p>
<a href="#@LocalizedStrings.PortabilitySummaryPageTitle">@LocalizedStrings.BackToSummary</a>
<a href="#@LocalizedStrings.PortabilitySummary">@LocalizedStrings.BackToSummary</a>
</p>
}
</div>
Expand All @@ -194,6 +196,7 @@
}

<table>
<caption>@LocalizedStrings.AvailableNuGetPackages</caption>
<tbody>
<tr>
@foreach (var header in nugetColumnHeaders)
Expand Down Expand Up @@ -232,7 +235,7 @@
</table>

<p>
<a href="#@LocalizedStrings.PortabilitySummaryPageTitle">@LocalizedStrings.BackToSummary</a>
<a href="#@LocalizedStrings.PortabilitySummary">@LocalizedStrings.BackToSummary</a>
</p>
</div>
}