Fix missing ProcessPartitionEventAsync handler #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
Oct 22, 2024
Member
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
LGTM but can you please also add a test with this constructor overload? If you need to unblock this release, it doesn't have to be now, but if so it would be good to create a ticket tracking the testing gap
Member
Author
|
As far as I know we don't really have a way to run automated tests using managed identity credentials. Once we finish #433 we should at least be able to catch this using a smoke test, though. Let's make sure as part of that PR that we have some sort of test in place. |
This was referenced Nov 26, 2025
This was referenced Dec 15, 2025
This was referenced Jan 13, 2026
This was referenced Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in #430, the handler registration was missing.
This appears to be a simple copy-paste mistake but it was not caught by testing because the tests use the other constructor overload.