Fix #178: Server IP parameter now accepts IPv6 addresses #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-ip` parameter for server mode failed to accept IPv6 addresses,
returning errors like "too many colons in address" or "Invalid IP address".
Root cause: The code concatenated IP and port directly (e.g., "2001:db8::1:8888"),
which is invalid for IPv6. IPv6 addresses must be bracketed: "[2001:db8::1]:8888".
Changes:
- Added formatListenAddress() helper function in utils.go to properly format
listen addresses for both IPv4 and IPv6
- Updated IP validation in ethr.go to accept bracketed IPv6 addresses
- Updated TCP and UDP servers in server.go to use the helper function
Behavior:
- IPv4: Works as before (e.g., "127.0.0.1:8888")
- IPv6: Now works correctly (e.g., "[::1]:8888")
- Empty IP: Works as before (":8888" for all interfaces)
Backward compatibility: Fully maintained. No changes to client behavior,
protocol, or command-line flags.
Testing:
- IPv4 server binding works
- IPv6 server binding works (with and without brackets)
- IPv6 client-server communication works
- All existing functionality preserved
Fixes microsoft#178
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-ipparameter for server mode failed to accept IPv6 addresses, returning errors like "too many colons in address" or "Invalid IP address".Root cause: The code concatenated IP and port directly (e.g., "2001:db8::1:8888"),
which is invalid for IPv6. IPv6 addresses must be bracketed: "[2001:db8::1]:8888".
Changes:
Behavior:
Backward compatibility: Fully maintained. No changes to client behavior, protocol, or command-line flags.
Testing:
Fixes #178