Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Click inside a child Dialog of a Popup closes the whole React tree  #1674

@chughkartikey

Description

@chughkartikey

Steps

  • Create a Popup with Dialog as a child item.
  • Create a button inside the Dialog

Expected Result

  • Click should not be considered as a click 'outside' pop-up since, dialog is a child of the pop-up.

Actual Result

  • Dialog and pop-up close with a click inside the dialog because Pop-up doesn't register the dialog as a child hence, during the calculations to find whether the click was inside of the children returns false and pop-up closes. This results in closing of the whole React tree since, for React it is infact the child.
  • Issue doesn't repro with Popup as a child of a Popup.

Example:

Metadata

Metadata

Assignees

No one assigned

    Labels

    vstsPaired with ticket in vsts

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions