Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Icon outline prop does not work in Button when using text prop #1967

@ckperez

Description

@ckperez

Bug Report

Steps

  1. Render a Button component with icon and text props
  2. Provide the icon prop with an object as its value, including the outline property
  3. Set the outline property to false

Expected Result

The Button should render as an icon without obvious Button styling AND the icon should be filled rather than an outline

Actual Result

The icon renders as an unfilled outline regardless of what the outline property is set to.

Note that this issue does not surface when the Icon is used as a standalone component, nor when used as a prop on Button without the text prop

Version

38.1 +

Testcase

https://codesandbox.io/embed/stardust-ui-example-vmccz

Metadata

Metadata

Assignees

No one assigned

    Labels

    vstsPaired with ticket in vsts

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions