Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

dropdownSearchInputStyles missing root key #753

@levithomason

Description

@levithomason

Bug Report

Steps

Call dropdownSearchInputStyles.root()

Expected Result

Styles for the root element should be provided.

Actual Result

TypeError: dropdownSearchInputStyles.root is not a function

Version

0.17.0

Testcase

See dropdownSearchInputStyles.ts, there is no root key. 💣

Fix Considerations

It seems there should be parity between the DropdownSearchInput and the Input components. However, the Input component conflates the wrapper and the root style targets.

It also seems there should be parity between components which have a wrapper part. However, the DropdownSearchInput, Input, and MenuItem are all different. These are different so that the intuitive usage of their component APIs is most correct, however, this seems to cause issues when trying to programmatically loop over the theme and deal with component styles.

It could be that we need to keep intuitive mappings at the component API level and keep programmatically consistent mappings at the style level. We need more thinking and resolution on this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    architecturevstsPaired with ticket in vsts🧰 bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions