Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
| <Grid variables={{ gridGap: '2rem' }} columns="1"> | ||
| {children} | ||
| </Grid> | ||
| </> |
There was a problem hiding this comment.
I don't see any reason to use there Flex...
| showCode: this.isActiveHash(), | ||
| componentVariables: {}, | ||
| showRtl: examplePath && examplePath.endsWith('rtl') ? true : false, | ||
| showRtl: examplePath && examplePath.endsWith('rtl'), |
There was a problem hiding this comment.
Simplified condition
| const childrenStyle: React.CSSProperties = { | ||
| paddingTop: 0, | ||
| paddingBottom: '10px', | ||
| maxWidth: pxToRem(500), |
There was a problem hiding this comment.
| </Flex.Item> | ||
|
|
||
| {/* TODO: bring back the right floating menu | ||
| <Grid columns="auto 300px" styles={{ justifyContent: 'normal', justifyItems: 'stretch' }}> |
There was a problem hiding this comment.
Fixes this issue:
|
|
||
| const TextExampleTruncated = () => ( | ||
| <div style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}> | ||
| <div style={{ overflow: 'hidden', textOverflow: 'ellipsis', width: 500 }}> |
There was a problem hiding this comment.
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 675 675
Lines 8756 8756
Branches 1558 1558
=======================================
Hits 7138 7138
Misses 1602 1602
Partials 16 16Continue to review full report at Codecov.
|
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Changes looks good to me! Are we planning to move the dropdown for switching teams back in the Sidebar or at least put some absolute positioning in order to prevent scrolling on each changing?
As I know there is a plan to move back theme selector |
3 participants
Continues work from #1014.