Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(chatBehavior): Use FocusZone mode Embed instead of Wrap #1044

Merged
sophieH29 merged 4 commits into from
Mar 12, 2019
Merged

fix(chatBehavior): Use FocusZone mode Embed instead of Wrap #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3804d24
fix(chatBehavior): Use FocusZone mode Embed instead of Wrap
Mar 11, 2019
63ce798
Merge branch 'master' into fix/chat-behavior-focus-zone-embed
sophieH29 Mar 11, 2019
a5df50d
update changelog
Mar 12, 2019
f08e71a
Merge branch 'master' into fix/chat-behavior-focus-zone-embed
sophieH29 Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Do not propagate keyboard events outside `Popup`'s content only when focus trap is used @sophieH29 ([#1028](https://github.com/stardust-ui/react/pull/1028))
- Narrate the first adding/selection of a `Dropdown` item using aria live @silviuavram ([#1032](https://github.com/stardust-ui/react/pull/1032))
- `*Props` interfaces accept additional props @layershifter ([#1042](https://github.com/stardust-ui/react/pull/1042))
- `chatBehavior` - Use `FocusZone`'s Embed mode instead of Wrap mode @sophieH29 ([#1044](https://github.com/stardust-ui/react/pull/1044))

### Features
- Add `inline` prop in the `Popup` for rendering the content next to the trigger element @mnajdova ([#1017](https://github.com/stardust-ui/react/pull/1017))
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/lib/accessibility/Behaviors/Chat/chatBehavior.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const ChatBehavior: Accessibility = (props: any) => ({
},
},
focusZone: {
mode: FocusZoneMode.Wrap,
mode: FocusZoneMode.Embed,
Copy link
Contributor

@mnajdova mnajdova Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog entry :)

props: {
shouldEnterInnerZone: event => keyboardKey.getCode(event) === keyboardKey.Enter,
direction: FocusZoneDirection.vertical,
Expand Down