Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore(package): update @types and TS#1046

Merged
layershifter merged 3 commits intomasterfrom
chore/update-ts
Mar 12, 2019
Merged

chore(package): update @types and TS#1046
layershifter merged 3 commits intomasterfrom
chore/update-ts

Conversation

@layershifter
Copy link
Member

Extracted from #1042.

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #1046 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage   81.77%   81.77%   -0.01%     
==========================================
  Files         687      687              
  Lines        8824     8822       -2     
  Branches     1567     1566       -1     
==========================================
- Hits         7216     7214       -2     
  Misses       1593     1593              
  Partials       15       15
Impacted Files Coverage Δ
packages/react/src/components/Ref/RefFindNode.tsx 100% <ø> (ø) ⬆️
packages/react/src/lib/createComponent.tsx 100% <ø> (ø) ⬆️
packages/react/src/lib/customPropTypes.tsx 45.51% <100%> (-0.38%) ⬇️
...react/src/components/Provider/ProviderConsumer.tsx 100% <100%> (ø) ⬆️
packages/react/src/components/Ref/Ref.tsx 100% <100%> (ø) ⬆️
packages/react/src/components/Ref/RefForward.tsx 100% <100%> (ø) ⬆️
packages/react/src/components/Flex/FlexItem.tsx 88.88% <100%> (-0.4%) ⬇️
...kages/react/src/components/Animation/Animation.tsx 90% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b733cd4...a011479. Read the comment docs.

Copy link
Collaborator

@bmdalex bmdalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, hope it's safe to make this change at this time though 👍

"tslint": "^5.11.0",
"tslint-config-airbnb": "^5.11.1",
"typescript": "~3.2.2",
"typescript": "^3.3.3333",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaaay 👍

@layershifter layershifter merged commit 04c2878 into master Mar 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/update-ts branch March 12, 2019 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants