feat(menu): pointing && vertical menu redlining

[jaanus03]

This PR is a minor update to vertical && pointing menu styles.
It removes bordered corners, straightens the "pointing" indicator and adds focus styles.

[mnajdova]

I am just wondering, do we really have purple left border in hoc theme?

[jaanus03]

I am just wondering, do we really have purple left border in hoc theme?

Hey. Good point. Probably not, but let me confirm.

[codecov]

Codecov Report

Merging #1116 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
+ Coverage   82.07%   82.09%   +0.01%     
==========================================
  Files         724      724              
  Lines        8663     8661       -2     
  Branches     1236     1234       -2     
==========================================
  Hits         7110     7110              
+ Misses       1536     1534       -2     
  Partials       17       17

Impacted Files	Coverage Δ
.../src/themes/teams/components/Menu/menuVariables.ts	66.66% <ø> (ø)	⬆️
...themes/teams-dark/components/Menu/menuVariables.ts	100% <ø> (ø)	⬆️
...src/themes/teams/components/Menu/menuItemStyles.ts	8.19% <0%> (+0.26%)	⬆️
...ms-high-contrast/components/Menu/menuItemStyles.ts	5.55% <0%> (-0.7%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0384c2c...e2e4d3b. Read the comment docs.

[jaanus03]

I am just wondering, do we really have purple left border in hoc theme?

You were right. No indicator in the HC theme. Removed it.

[codepretty]

I would consider renaming this to something without "primary" in it. It might make people think they need the primary prop, which they don't.

[jaanus03]

Correct. Renamed it.

[codepretty]

I find this ternary operator difficult to read. Would it be easier to scan if this were flat, like

...(pointing && vertical && !isFromKeyboard && {
    styles here
}),
...(pointing && !vertical && {
    styles here
}),

[jaanus03]

Done.

[codepretty]

I think you can remove this

[jaanus03]

Done

[codepretty]

Read my comments and consider addressing before checking in