This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(chatBehavior): remove role "presentation"#1137
Merged
Conversation
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
approved these changes
Mar 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 729 729
Lines 8679 8679
Branches 1167 1167
=======================================
Hits 7149 7149
Misses 1515 1515
Partials 15 15
Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Mar 29, 2019
delete-merged-branch
bot
deleted the
fix/chat-behavior-remove-role-presentation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aria-label is not read on chat when role="presentation" is set