This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusTrapZone): do not propagate any keyboard events#1180
Merged
fix(FocusTrapZone): do not propagate any keyboard events#1180
Conversation
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
- Coverage 82.37% 82.36% -0.01%
==========================================
Files 733 733
Lines 8720 8716 -4
Branches 1165 1231 +66
==========================================
- Hits 7183 7179 -4
Misses 1522 1522
Partials 15 15
Continue to review full report at Codecov.
|
kuzhelov
reviewed
Apr 5, 2019
|
|
||
| ### Fixes | ||
| - Truncate `content` and `header` of `ListItem` when used from `DropdownSelectedItem` @silviuavram ([#1161](https://github.com/stardust-ui/react/pull/1161)) | ||
| - `FocusTrapZone` - Do not propagate any keyboard events @sophieH29 ([#1180](https://github.com/stardust-ui/react/pull/1180)) |
Contributor
There was a problem hiding this comment.
could you, please, provide some notes about resolution strategy in this PR's description - I mean, specifically
- what was the cause of the issue
- why this was considered as a fix
This description will help a lot to better understand why provided changes are considered to be a fix for the issue, as well as to retrospect this case if we will experience similar problem in future. Thank you!
mnajdova
approved these changes
Apr 5, 2019
kuzhelov
approved these changes
Apr 5, 2019
sophieH29
deleted the
fix/focus-trap-zone-do-not-propagate-keyboard-events
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1156
Issues caused:
Because of
Portalevents propagating to the parent components in React element tree, it caused post-effects: keyboard event was propagated outsidePortal, and was handled by another component too. (Issue example #1156)Why:
FocusTrapZoneshould not only trap focus but totally block user interaction outside of it - i.e. stop propagating keyboard events.