Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(List): fix propTypes warning in ListItem #1266

Merged
layershifter merged 3 commits into from
Apr 25, 2019
Merged

fix(List): fix propTypes warning in ListItem #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2891b9b
fix(List): fix propTypes warning in ListItem
layershifter Apr 25, 2019
fd17ba0
add changelog entry
layershifter Apr 25, 2019
65c1015
Update CHANGELOG.md
layershifter Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Fixes
- Update `ChatMessage` styles in Teams themes @layershifter ([#1246](https://github.com/stardust-ui/react/pull/1246))
- Fix `propTypes` warning in `ListItem` @layershifter ([#1266](https://github.com/stardust-ui/react/pull/1266))

<!--------------------------------[ v0.29.0 ]------------------------------- -->
## [v0.29.0](https://github.com/stardust-ui/react/tree/v0.29.0) (2019-04-24)
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/components/List/ListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,15 +178,15 @@ class ListItem extends UIComponent<ReactProps<ListItemProps>, ListItemState> {
},
})

const hasHeaderPart = headerElement || headerMediaElement
const hasHeaderPart = !!(headerElement || headerMediaElement)
const headerPart = hasHeaderPart && (
<>
<Flex.Item grow>{headerElement}</Flex.Item>
{headerMediaElement}
</>
)

const hasContentPart = contentElement || contentMediaElement
const hasContentPart = !!(contentElement || contentMediaElement)
const contentPart = hasContentPart && (
<>
<Flex.Item grow>{contentElement}</Flex.Item>
Expand Down