Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(Popup): add mountNode and mountDocument#1288

Merged
layershifter merged 7 commits intomasterfrom
feat/popup-mountnode
May 9, 2019
Merged

feat(Popup): add mountNode and mountDocument#1288
layershifter merged 7 commits intomasterfrom
feat/popup-mountnode

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented May 3, 2019

BREAKING CHANGES

context was renamed to mountNode in PortalInner to be consistent. It matches SUIR naming.

Before

<PortalInner context={document.body} />

After

<PortalInner mountNode={document.body} />

Two props added to Popup component

  1. mountNode to define an element where popup should be bound to:
<Popup mountNode={document.body} />
<Popup mountNode={document.getElementById('popup-areas')} />
  1. mountDocument to define a target for listeners:
<Popup mountDocument={innerDocument} />

@layershifter layershifter changed the title Feat/popup mountnode feat(Popup): add mountNode and mountDocument May 3, 2019
@layershifter layershifter force-pushed the feat/popup-mountnode branch from 2887e76 to c6a9ad7 Compare May 7, 2019 09:12
@layershifter layershifter marked this pull request as ready for review May 7, 2019 10:56
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #1288 into master will increase coverage by 0.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
+ Coverage   72.83%   72.85%   +0.01%     
==========================================
  Files         747      747              
  Lines        5654     5658       +4     
  Branches     1632     1633       +1     
==========================================
+ Hits         4118     4122       +4     
  Misses       1529     1529              
  Partials        7        7
Impacted Files Coverage Δ
...ckages/react/src/components/Portal/PortalInner.tsx 100% <100%> (ø) ⬆️
packages/react/src/components/Popup/Popup.tsx 69.04% <92.3%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f08626...5d8b31e. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants