This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(dropdown): align, position, offset props + automatic position#1294
Closed
feat(dropdown): align, position, offset props + automatic position#1294
Conversation
351106c to
fd387e2
Compare
b21926a to
4961112
Compare
Codecov Report
@@ Coverage Diff @@
## master #1294 +/- ##
==========================================
+ Coverage 72.17% 72.21% +0.03%
==========================================
Files 753 756 +3
Lines 5621 5629 +8
Branches 1671 1648 -23
==========================================
+ Hits 4057 4065 +8
Misses 1557 1557
Partials 7 7
Continue to review full report at Codecov.
|
Collaborator
Generated by 🚫 dangerJS |
91e5fec to
8770717
Compare
* Popup experiment * cleanup * more cleanups * rename file * add changelog entries * add "implements PopperJS.ReferenceObject" * replace `triggerDomElement` with `triggerRef.current` * update typings * rewrite to WeakMap * update comment * remove memoization
8770717 to
614669d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(dropdown): align, position, offset props + automatic position
This PR tackles:
align,position,offsetprops forDropdowncomponentDropdownresultsTODO:
src/lib/positionerPositionerhelper component toPopupandDropdownpositionerHelper(move fromPopup-test.tsxto dedicated file)Dropdowntrigger and list of resultsany ideas?