Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(Input): clear by Escape keydown when Input is clearable#1306

Merged
silviuaavram merged 9 commits intomasterfrom
fix-clearable-input
May 10, 2019
Merged

fix(Input): clear by Escape keydown when Input is clearable#1306
silviuaavram merged 9 commits intomasterfrom
fix-clearable-input

Conversation

@silviuaavram
Copy link
Collaborator

Fixes #1024

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #1306 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
+ Coverage   72.34%   72.36%   +0.01%     
==========================================
  Files         758      758              
  Lines        5680     5684       +4     
  Branches     1686     1663      -23     
==========================================
+ Hits         4109     4113       +4     
  Misses       1565     1565              
  Partials        6        6
Impacted Files Coverage Δ
...lib/accessibility/Behaviors/Input/inputBehavior.ts 100% <ø> (ø) ⬆️
packages/react/src/components/Input/Input.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37fbf87...d1b1d5d. Read the comment docs.

@silviuaavram silviuaavram merged commit bc99151 into master May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-clearable-input branch May 10, 2019 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility] Input component "clear" button is not keyboard accessible

2 participants