This repository was archived by the owner on Mar 4, 2020. It is now read-only.
docs(Accessibility): improve acc descriptions for components#1371
Merged
jurokapsiar merged 8 commits intomasterfrom May 25, 2019
Merged
docs(Accessibility): improve acc descriptions for components#1371jurokapsiar merged 8 commits intomasterfrom
jurokapsiar merged 8 commits intomasterfrom
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Collaborator
Changed dependencies in
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
=======================================
Coverage 73.47% 73.47%
=======================================
Files 778 778
Lines 5859 5859
Branches 1706 1706
=======================================
Hits 4305 4305
Misses 1548 1548
Partials 6 6
Continue to review full report at Codecov.
|
hughreeling
reviewed
May 22, 2019
bmdalex
reviewed
May 24, 2019
Collaborator
bmdalex
left a comment
bmdalex
left a comment
There was a problem hiding this comment.
pls check the new dependency with the people I mentioned
| "react-dom": "^16.8.6", | ||
| "react-element-to-jsx-string": "^14.0.2", | ||
| "react-hot-loader": "^4.8.2", | ||
| "react-markdown": "^4.0.8", |
Collaborator
There was a problem hiding this comment.
@layershifter @kuzhelov @miroslavstastny
- are we ok with adding this dependency?
- can we suggest some existing tooling to achieve this?
Member
There was a problem hiding this comment.
can we suggest some existing tooling to achieve this?
Nope
are we ok with adding this dependency?
Yep, it's only for docs
bmdalex
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve acc descriptions for components