This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(input): fixing Firefox placeholder color#1406
Merged
Conversation
notandrew
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
notandrew
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
=======================================
Coverage 73.59% 73.59%
=======================================
Files 787 787
Lines 5890 5890
Branches 1718 1718
=======================================
Hits 4335 4335
Misses 1549 1549
Partials 6 6
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1310
Firefox applies a .4 opacity to input placeholders - this will just normalize the placeholders to 1.0 opacity.